Floyd: Has to cross your mind in this discussion, but his superstardom is such a strictly US thing that I can't see how he'd make the top ten - although he may not be that far off. I don't know. He did make more money than anyone else, which is noteworthy, of course (and there is probably such a thing as "money charisma"). It's just that outside of America and certain demographics (those that don't go a big yaaaaaawn at his "look at all my money" schtick) he never really caught the mainstream's attention. And even with his much (self-)publicised spending, he's just too bland and unmemorable outside the ring to be a true icon of the sport. Certainly in a historic perspective he's not. He'll most likely be forgotten by the mainstream somewhat quickly, and he seems to be fairly aware of that fact himself. People in the sport, along with true boxing fans, won't forget, obviously - but that's not really what we're talking about here.
As for Floyd's fights against De La Hoya, Pac and McGregor being huge, you'd have to consider that Manny Pacquiao and Conor McGregor are bigger stars worldwide than Floyd will ever be, and De La Hoya was huge in the Americas (and hardly unknown elsewhere), so I wouldn't give Floyd all the credit for setting those PPV records. When he wasn't fighting big names his fights weren't actually getting much attention at all in non-American media, and even PPV numbers - a US thing - weren't terribly impressive. So... Biggest earner, for various reasons. But not top ten here.